Range slider component #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 26, 2018 18:55
y0hami
added
type/feat
prudho
reviewed
Aug 13, 2018
src/definitions/modules/range.js
Outdated
| @@ -0,0 +1,273 @@ | |||
| /*! | |||
| * # Range slider for Semantic UI. | |||
There was a problem hiding this comment.
Could you set the standard header ? Here it is:
/*!
* # Semantic UI - Range slider
* http://github.com/semantic-org/semantic-ui/
*
*
* Released under the MIT license
* http://opensource.org/licenses/MIT
*
*/
prudho
reviewed
Aug 13, 2018
| }, | ||
|
|
||
| }; | ||
|
|
There was a problem hiding this comment.
Not a blocking stuff, but we should add later common modules methods (debug, performance, display, verbose...).
There was a problem hiding this comment.
Good shout, didn't think of that
prudho
previously approved these changes
Aug 13, 2018
ColinFrick
previously approved these changes
Aug 14, 2018
y0hami
added
state/awaiting-changes
ColinFrick
approved these changes
Aug 16, 2018
prudho
approved these changes
Aug 16, 2018
Closed
y0hami
added
state/has-docs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the range slider component made by @tyleryasaka.
Range repo issue: tyleryasaka/semantic-ui-range#30
Closed Issues
Semantic-Org/Semantic-UI#1336